Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible defaults for riak_control #178

Merged
merged 1 commit into from
Jan 31, 2014
Merged

Sensible defaults for riak_control #178

merged 1 commit into from
Jan 31, 2014

Conversation

joedevivo
Copy link
Contributor

Option 3 as described in basho/platform_tasks#57

@gburd
Copy link

gburd commented Jan 31, 2014

+1

  • this sets a rational default (no auth implied for Riak Control) and
  • when password auth is enabled doesn't create any pre-defined default for user/pass, forcing the admin to do that rather than depend on insecure defaults (see: scott/tiger)

@joedevivo
Copy link
Contributor Author

For the record, here's the new generated riak.conf section


## Set to 'off' to disable the admin panel.
## 
## Default: off
## 
## Acceptable values:
##   - on or off
riak_control = off

## Authentication mode used for access to the admin panel.
## 
## Default: off
## 
## Acceptable values:
##   - one of: off, userlist
riak_control.auth.mode = off

## If riak control's authentication mode (riak_control.auth.mode)
## is set to 'userlist' then this is the list of usernames and
## passwords for access to the admin panel.
## 
## Acceptable values:
##   - text
## riak_control.auth.user.user.password = pass

@cmeiklejohn
Copy link
Contributor

👍 to merge, riak_control_authentication passing, code looks good.

@jmshoffs0812
Copy link

+1

joedevivo added a commit that referenced this pull request Jan 31, 2014
Sensible defaults for riak_control
@joedevivo joedevivo merged commit c0e9d56 into develop Jan 31, 2014
@joedevivo joedevivo deleted the jd-bolth branch January 31, 2014 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants