Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ember-1.0.0 and the latest ember-data beta #143

Merged
merged 1 commit into from
Sep 12, 2013
Merged

Upgrade to ember-1.0.0 and the latest ember-data beta #143

merged 1 commit into from
Sep 12, 2013

Conversation

vanstee
Copy link
Contributor

@vanstee vanstee commented Sep 5, 2013

Yay! The upgrade to Ember 1.0.0 is here. The following is a list of some major stuff that was changed:

  • Swapped out all the ember related vendored javascript files for the
    new most stable versions
  • Rewrote the router to use the new DSL
  • Namespaced controller and view
  • Removed a lot of code that is now unnecessary due to better defaults

Fixes #95

@vanstee
Copy link
Contributor Author

vanstee commented Sep 5, 2013

Fixed most of the easy stuff. Still have some work to do updating the view action handlers in cluster.js. 🔜

@cmeiklejohn
Copy link
Contributor

Looks great so far; let me know if I can answer any questions.

@cmeiklejohn cmeiklejohn mentioned this pull request Sep 5, 2013
Closed
@vanstee
Copy link
Contributor Author

vanstee commented Sep 6, 2013

All that's left is to get rid of these:

DEPRECATION: Action handlers implemented directly on controllers are deprecated in favor of action handlers on an `actions` object

@vanstee
Copy link
Contributor Author

vanstee commented Sep 6, 2013

Sorry for the code 💣 but I guess that's just how these things go.

I'm a little scared that I might have missed something since this is really my first experience using riak_control and the test suite doesn't seem to cover some of UI related stuff. Let me know if you find anything terribly broken while testing.

@vanstee
Copy link
Contributor Author

vanstee commented Sep 6, 2013

Oh also, looks like we'll need to update the object transform to the new style in #115.

https://github.com/basho/riak_control/pull/115/files#L1R14

I can rebase onto that branch and make the change if that's easiest.

@cmeiklejohn
Copy link
Contributor

Is this good to go? If so, let's rebase it!

@vanstee
Copy link
Contributor Author

vanstee commented Sep 10, 2013

Yep. Will do.

@cmeiklejohn
Copy link
Contributor

Also, is everything working as far as you can tell, or is there further work that needs to happen? If so, can you detail that work in this PR so I can take a pass as fixing it?

@vanstee
Copy link
Contributor Author

vanstee commented Sep 10, 2013

Everything seems to be working. I'm pretty sure I tested everything but I might have missed something.

@vanstee
Copy link
Contributor Author

vanstee commented Sep 10, 2013

Oh did you mean rebase onto #115 or should I hold off on that for now?

@cmeiklejohn
Copy link
Contributor

Do not rebase #115, as it will not be merged.

@vanstee
Copy link
Contributor Author

vanstee commented Sep 10, 2013

Rebased and ready to go. Let me know if you have any questions.

@vanstee vanstee mentioned this pull request Sep 10, 2013
Closed
@cmeiklejohn
Copy link
Contributor

Ah, my fault. I wasn't clear. Do you mind squashing this into one commit?

@vanstee
Copy link
Contributor Author

vanstee commented Sep 11, 2013

Sure.

@vanstee
Upgrade to ember-1.0.0 and latest ember-data beta
2ff7904 
* Swapped out all the ember related vendored javascript files for the
  new most stable versions
* Rewrote the router to use the new DSL
* Namespaced controller and view
* Removed a lot of code that is now unnecessary due to better defaults
@cmeiklejohn
Copy link
Contributor

This looks great. I'm 👍

cmeiklejohn added a commit that referenced this pull request Sep 12, 2013
@cmeiklejohn
Merge pull request #143 from vanstee/upgrade-ember
9e326f0 
Upgrade to ember-1.0.0 and the latest ember-data beta.
@cmeiklejohn cmeiklejohn merged commit 9e326f0 into basho:develop Sep 12, 2013
@vanstee vanstee deleted the upgrade-ember branch September 12, 2013 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Kanban-Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Ember.js
2 participants
@vanstee @cmeiklejohn