Honor configured cipher suites and add an option to honor the order #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added some tunables for TLS version and whether to check CRLs. |
|
how do I test this? |
|
You can test it, via https, with gnutls-cli-debug, which will print the cipher suites selected. I was going to write a riak_test, but ran out of time. I can do it once we hit the testing phase. |
| CipherOrder = cuttlefish_util:conf_get_value("honor_cipher_order", Conf), | ||
| %% This is only available, as of December 2013, in basho patched R16B02, | ||
| %% so disable it if the VM is not patched by basho. This can be revised | ||
| %% for R17, when this patch is expected to be present mainline. |
There was a problem hiding this comment.
think it's worth adding a link to the basho tag? https://github.com/basho/otp/tree/OTP_R16B02_basho3
|
eunit test failures: https://gist.github.com/metadave/8059507 |
The default is to only allow TLS 1.2 and to check the CRL of any client certificates. This addresses some of the concerns in basho/riak#433
|
Rebased to fix the eunit failures and addressed review comments. |
|
eunit tests pass after rebasing: https://gist.github.com/metadave/8061127 |
|
+1 |
bookshelfdave
pushed a commit
that referenced
this pull request
Dec 20, 2013
Honor configured cipher suites and add an option to honor the order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In additional to using the cipher suites configured in riak_core, you can also tell OTP to prefer the order in which the cipher suite is listed in Riak, over any client preferences. This is more secure as it allows the server to order the ciphers such that it can put the ciphers with the attributes it values the most at the top of the list, but list others for compatability.
This new option, as it is only available in a patched OTP, can only be passed to the SSL api if it is being enabled. To avoid crashing Riak built with unpatched VMs, cuttlefish will automatically switch this option off on non-patched VMs.
See also basho/riak_core#469