Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm.args support for node_package #86

Merged
merged 1 commit into from
Sep 3, 2013
Merged

vm.args support for node_package #86

merged 1 commit into from
Sep 3, 2013

Conversation

joedevivo
Copy link
Contributor

So, the output in a cuttlefish world looks like this:

➜  riak git:(jd-cuttlefish) ✗ ./rel/riak/bin/riak console
egrep: /Users/joe/dev/basho/riak/rel/riak/bin/../etc/vm.args: No such file or directory
grep: /Users/joe/dev/basho/riak/rel/riak/bin/../etc/vm.args: No such file or directory
Node 'riak@127.0.0.1' not responding to pings.
11:56:27.914 [info] Application lager started on node nonode@nohost
11:56:27.914 [info] No app.config detected in /Users/joe/dev/basho/riak/rel/riak/bin/../etc, activating cuttlefish
config is OK
-config /Users/joe/dev/basho/riak/rel/riak/bin/../etc/generated/app.2013.08.29.11.56.27.config -args_file /Users/joe/dev/basho/riak/rel/riak/bin/../etc/generated/vm.2013.08.29.11.56.27.args
Exec: /Users/joe/dev/basho/riak/rel/riak/bin/../erts-5.9.3.1/bin/erlexec -boot /Users/joe/dev/basho/riak/rel/riak/bin/../releases/1.4.0/riak               -config /Users/joe/dev/basho/riak/rel/riak/bin/../etc/generated/app.2013.08.29.11.56.27.config -args_file /Users/joe/dev/basho/riak/rel/riak/bin/../etc/generated/vm.2013.08.29.11.56.27.args              -pa /Users/joe/dev/basho/riak/rel/riak/bin/../lib/basho-patches -- console
Root: /Users/joe/dev/basho/riak/rel/riak/bin/..
Erlang R15B03 (erts-5.9.3.1) [source] [64-bit] [smp:4:4] [async-threads:64] [kernel-poll:true]

Eshell V5.9.3.1  (abort with ^G)
(riak@127.0.0.1)1> q().
ok

As you can see, there are some egrep errors I'm going to need some help hiding, since those errors aren't actually important. I figure @jaredmorrow can school me on some sh in the process.

Also, some comments in-line where helpful.

@@ -56,8 +56,11 @@ echoerr() { echo "$@" 1>&2; }
# Extract the target node name from node.args
NAME_ARG=`egrep '^\-s?name' $RUNNER_ETC_DIR/vm.args`
if [ -z "$NAME_ARG" ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nested if. If name's in vm.args, use it. If not, check conf file.

@jaredmorrow
Copy link
Contributor

+1, please squash before merging.

removed -sname support
joedevivo added a commit that referenced this pull request Sep 3, 2013
vm.args support for node_package
@joedevivo joedevivo merged commit 905bba0 into develop Sep 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants