Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source default config files in env.sh #149

Merged
merged 1 commit into from
Jul 11, 2014

Conversation

jaredmorrow
Copy link
Contributor

See description of the bug in the below linked issue. This change moves the sourcing of configuration options into the env.sh now that we changed from sudo to su and lost our environment settings.

Fixes: basho/riak#563

Tested on Ubuntu 14.04 and tested a devrel to ensure it doesn't affect it.

Test Run

(Reading database ... 60884 files and directories currently installed.)
Preparing to unpack riak-ee_2.0.0beta7-369ad9b8-1_amd64.deb ...
Unpacking riak-ee (2.0.0beta7-369ad9b8-1) ...
Setting up riak-ee (2.0.0beta7-369ad9b8-1) ...
Adding group `riak' (GID 113) ...
Done.
Adding system user `riak' (UID 108) ...
Adding new user `riak' (UID 108) with group `riak' ...
Not creating home directory `/var/lib/riak'.
Processing triggers for ureadahead (0.100.0-16) ...
Processing triggers for man-db (2.6.7.1-1) ...
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ riak ping
You need to be root or use sudo to run this command
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo riak ping
Node 'riak@127.0.0.1' not responding to pings.
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo riak start
!!!!
!!!! WARNING: ulimit -n is 1024; 65536 is the recommended minimum.
!!!!
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo riak ping
pong
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ cat /etc/default/riak
cat: /etc/default/riak: No such file or directory
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo riak stop
ok
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo vi /etc/default/riak
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ cat /etc/default/riak
export WAIT_FOR_ERLANG=1
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo riak ping
Node 'riak@127.0.0.1' not responding to pings.
vagrant@vagrant-ubuntu-trusty-64:/vagrant$ sudo riak start
!!!!
!!!! WARNING: ulimit -n is 1024; 65536 is the recommended minimum.
!!!!
riak failed to start within 1 seconds,
see the output of 'riak console' for more information.
If you want to wait longer, set the environment variable
WAIT_FOR_ERLANG to the number of seconds to wait.

@jaredmorrow
Copy link
Contributor Author

@glickbot +1'd on the issue after a visual review. I'm going to merge for now, then test the RC build and close out the issue if the RC build works for him.

jaredmorrow added a commit that referenced this pull request Jul 11, 2014
Source default config files in env.sh
@jaredmorrow jaredmorrow merged commit 0077482 into develop Jul 11, 2014
@hectcastro
Copy link
Contributor

The RC looks good on these platforms:

  • ubuntu-1404
  • ubuntu-1204
  • centos-65
  • centos-510
  • debian-74
  • debian-608

@jaredmorrow
Copy link
Contributor Author

Thanks @hectcastro

@seancribbs seancribbs deleted the jem-source-default-scripts branch April 1, 2015 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env variables (i.e. WAIT_FOR_ERLANG) do not persist during startup.
2 participants