Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for extra cuttlefish commands #106

Merged
merged 5 commits into from
Nov 13, 2013
Merged

Conversation

joedevivo
Copy link
Contributor

Added support for

  • $runner config effective
  • $runner config describe VARIABLE

@jaredmorrow
Copy link
Contributor

Calling riak config does not print out any help describing the possible commands.

@jaredmorrow
Copy link
Contributor

The riak config describe command should catch the arg count at the shell level to prevent leaking cuttlefish output through to the shell.

./bin/riak config describe 
cuttlefish's describe command required a variable to query.
Try `describe setting.name`

Users would most likely think, "what does a cuttlefish have to do with anything?"

@joedevivo
Copy link
Contributor Author

That's actually hardcoded io:format in cuttlefish's escript. I can change the wording over there to be "The describe command...", but that shouldn't hold up this review.

@jaredmorrow
Copy link
Contributor

No, what I'm saying is you can catch the fact that there are not enough params given to 'config describe' and print help. That will tie into not enough params to 'config'

@joedevivo
Copy link
Contributor Author

Ooooh. I get it.

@jaredmorrow
Copy link
Contributor

https://github.com/basho/riak/blob/develop/rel/files/riak-admin#L199 bucket-type or security subcommands are good examples.

@jaredmorrow
Copy link
Contributor

Nothing big, just minor user friendliness fixes.

@joedevivo
Copy link
Contributor Author

Yeah, that's the whole point of the cuttlefish stuff, so I'm all for this kind of attention

@jaredmorrow
Copy link
Contributor

+1

joedevivo added a commit that referenced this pull request Nov 13, 2013
added support for extra cuttlefish commands
@joedevivo joedevivo merged commit ba81fc9 into develop Nov 13, 2013
@jaredmorrow jaredmorrow deleted the jd-cuttlemands branch March 28, 2014 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants