Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv async close #99

Merged
merged 2 commits into from
Oct 17, 2013
Merged

Mv async close #99

merged 2 commits into from
Oct 17, 2013

Conversation

matthewvon
Copy link
Contributor

This is async close code originally released in 1.4.2-turner.

Discussion is here: https://github.com/basho/leveldb/wiki/mv-async-close

@ghost ghost assigned matthewvon Oct 14, 2013
@kellymclaughlin
Copy link

I rebased this branch from the HEAD of master in order to run the eleveldb tests and it rebases cleanly and all the eunit tests pass.

@kellymclaughlin
Copy link

I ran the leveldb unit tests with make check and all tests pass.

@kellymclaughlin
Copy link

The 1.4.2-turner branch contained the same changes that are represented here. I used that branch and ran the entire Riak CS riak_test suite. That gives me assurance that this change does not break any critical functionality at least from the perspective of Riak CS.

@kellymclaughlin
Copy link

This change has been deployed on a customer's system that was experiencing this issue. We have observed that this change works as intended to resolve the issue.

@kellymclaughlin
Copy link

👍 Great work!

matthewvon pushed a commit that referenced this pull request Oct 17, 2013
@matthewvon matthewvon merged commit 82604c9 into master Oct 17, 2013
@matthewvon matthewvon deleted the mv-async-close branch May 5, 2016 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants