Fix version_set compilation bug #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, pull request accepted. Will merge soon. What platform / compiler gave warning / error? I would like to reproduce. |
|
In a perfect world I would be able to find OSX 10.7.x machine with related XCode to verify before / after effects of the change. In my world that did not happen. I have verified that the change does NOT break my 10.8 OSX XCode and Linux builds. Also found C or C++ spec validating the usage ... merging. |
matthewvon
pushed a commit
that referenced
this pull request
Oct 14, 2013
Fix version_set compilation bug
|
p.s. I manually made the same change in branch mv-hot-threads1 ... expect a merge conflict there until that branch goes to master also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.