activate the AssertHeld() logic of Mutex and Spin classes. And address issue #100 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2014 09:26
…ns (error found by code in issue #100). Populate Mutex.AssertHeld() code ... Google, why left empty?
matthewvon
changed the title
This was referenced Mar 21, 2014
I couldn't get Scott's test in eleveldb to run, but it passed for him and Matthew. 👍 |
matthewvon
pushed a commit
that referenced
this pull request
Mar 25, 2014
activate the AssertHeld() logic of Mutex and Spin classes. And address issue #100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scary to find that Mutex.AssertHeld() test, used throughout the leveldb code, performs no test. This adds the necessary assert logic. PR is for post-Riak 2.0 code freeze.
I used this code on a really long Bulk test sequence. It did not find any mutex problems … thankfully.
This branch also contains an adjustment to VersionSet::LogAndApply(). Scott Fritchie created a test to randomly fail fail accesses. That test found a flaw in the LogAndApply() logic flow that was adjusted for 2.0. The logic flow now correctly differentiates between file failures and write failures … i.e. does not segfault.