-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mv dynamic block size #111
Conversation
…achine. needs work for production.
… mv-dynamic-block-size
…t compactions. address unrelated concern about file numbers and threads ... looks unnecessary, but safer
} // if | ||
} // if | ||
|
||
last_low_mem_=env_->NowMicros(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe set last_low_mem_=block_size_changed_
instead of calling env->NowMicros()
again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intended change was to have all env_->NowMicros() calls use variable "now". Must have gotten distracted. Fixing that and moving last_low_mem_ higher in the block with a descriptive comment.
👍 Nice work @matthewvon |
Branch description is here: https://github.com/basho/leveldb/wiki/mv-dynamic-block-size