Remove PropEr dependency. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test:
|
ghost
assigned 
|
Followed the above steps, and expected tests pass. |
tburghart
added a commit
to basho/hamcrest-erlang
that referenced
this pull request
Jan 17, 2017
- Replaces how hamcrest.hrl is generated, see comments in
priv/build/scripts/generate_include.escript
- Moved .app to src, where Rebar3 will always find it.
- Rewrote some specs to make dialyzer happy.
- Made hamcrest:matchspec non-opaque, because that just doesn't work with a shared record definition.
- Adds Thumbs support.
At present, tests require QuviQ Erlang QuickCheck, and will be skipped (returning success) if it's not installed.
This commit removes support for PropEr due to its license.
Refer to:
basho/erlang_protobuffs#19
proper-testing/proper#29
It _may_ be worth supporting Triq at some point:
https://github.com/krestenkrab/triq
tburghart
added a commit
to basho/hamcrest-erlang
that referenced
this pull request
Jan 18, 2017
- Replaces how hamcrest.hrl is generated, see comments in
priv/build/scripts/generate_include.escript
- Moved .app to src, where Rebar3 will always find it.
- Rewrote some specs to make dialyzer happy.
- Made hamcrest:matchspec non-opaque, because that just doesn't work with a shared record definition.
- Adds Thumbs support.
At present, tests require QuviQ Erlang QuickCheck, and will be skipped (returning success) if it's not installed.
This commit removes support for PropEr due to its license.
Refer to:
basho/erlang_protobuffs#19
proper-testing/proper#29
It _may_ be worth supporting Triq at some point:
https://github.com/krestenkrab/triq
russelldb
pushed a commit
that referenced
this pull request
Apr 23, 2018
Will now add bundle information to MANIFEST in .jar Also: Removed unneeded dependencies. Changed to use rotobuf-maven-plugin from maven central Fixes #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For licensing reasons, Basho cannot bundle PropEr with Riak, and so protobuffs cannot have it as a dependency.
This PR removes the direct dependency on PropEr, making it possible to use EQC in its place, or have the appropriate pieces stubbed out when neither is available. The known
skip_next_fieldfailure still exists in the PropEr-based tests, but all other properties and unit tests pass with the shims.