Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv compress option #109

Merged
merged 3 commits into from
Apr 7, 2014
Merged

Mv compress option #109

merged 3 commits into from
Apr 7, 2014

Conversation

matthewvon
Copy link
Contributor

Bring the compression option to cuttlefish. Developers want it (namely Matthew) and customers on mailing list are talking about how they disable compression in favor of ZFS compression. This needs to be available.

@michellep-basho
Copy link

+1 from Product

@angrycub
Copy link
Contributor

angrycub commented Apr 1, 2014

+1 CSE

@joedevivo
Copy link
Contributor

this should be unit tested.

@joedevivo
Copy link
Contributor

Did a make clean, then a make compile and pulled all new deps. this branch isn't building for me:

Compiling c_src/eleveldb.cc
c_src/eleveldb.cc:334:26: error: no member named 'block_cache_threshold' in 'leveldb::Options'
                    opts.block_cache_threshold = memory_sz;
                    ~~~~ ^
1 error generated.
ERROR: compile failed while processing /Users/joe/dev/basho/eleveldb: rebar_abort
make: *** [compile] Error 1

@matthewvon
Copy link
Contributor Author

rm -rf c_src/leveldb
make
make test

not my fault rebar is trash.

@joedevivo
Copy link
Contributor

+1, thanks!

matthewvon pushed a commit that referenced this pull request Apr 7, 2014
@matthewvon matthewvon merged commit deea5ef into develop Apr 7, 2014
@seancribbs seancribbs deleted the mv-compress-option branch April 1, 2015 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants