Add JSON writer #47 [JIRA: RIAK-1486] #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basho-JIRA
added
JIRA: To Do
JIRA: In Progress
JIRA: Needs Review
and removed
JIRA: To Do
JIRA: In Progress
labels
|
_[posted via JIRA by Nick Marino]_ |
|
@nickelization This code looks great and works like a charm! The only suggestion I have is maybe adding a newline after the output. I'm not sure if that causes problems with json parsing, but it will make things look nicer on the cli or redirects to files. |
|
👍 a91239d |
borshop
added a commit
that referenced
this pull request
Jan 27, 2015
Add JSON writer #47 [JIRA: RIAK-1486] Reviewed-by: andrewjstone
We need to return a 2-tuple with iolists for stdout and stderr to conform to the new clique_writer API.
|
👍 a646e7f |
borshop
added a commit
that referenced
this pull request
Mar 10, 2015
Add JSON writer #47 [JIRA: RIAK-1486] Reviewed-by: andrewjstone
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a JSON writer module to clique. It is only enabled at startup if the mochijson2 module can be found. It can be used by specifying --format=json on the command line.