Fixes for 'faulterl'-style fault injection #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes include these slightly larger patches: * reshuffle to avoid var binding shadows * restrict pattern match to throw exception to catch at caller
Including: * list_data_files() fails * Fix file-scan exceptions in merge() * Fix EUnit bitcask:merge_test() * Partial merge check should be after file opens fail/succeed
Also, add minor '_ = ' pattern match to make Dialyzer happier
| throw:Reason -> | ||
| Reason; | ||
| _X:_Y -> | ||
| io:format(user, "X Y = ~p ~p\n", [_X, _Y]), |
There was a problem hiding this comment.
Fix pushed. Any other review comments?
|
Any other review/fixit tasks? |
| %% | ||
| %% ------------------------------------------------------------------- | ||
| -module(generic_qc_fsm). | ||
| %% Borrowed heavily from bitcask_qc_fsm.erl |
There was a problem hiding this comment.
I'm all right with these being separate for now, but if they're very similar, should we consider merging them and then running it twice in make test, once with and one without fault injection?
|
+1 1cf14a1 |
borshop
added a commit
that referenced
this pull request
Apr 16, 2014
Fixes for 'faulterl'-style fault injection Reviewed-by: evanmcc
|
@borshop: merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and squashed version of the
slf-faulterl-introductionbranch. The squashes have attempted to use roughly one commit for: