Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuttlefish schema RHS sub for platform_bin_dir #138

Merged
merged 3 commits into from
Feb 13, 2014
Merged

Cuttlefish schema RHS sub for platform_bin_dir #138

merged 3 commits into from
Feb 13, 2014

Conversation

joedevivo
Copy link
Contributor

also, rearranged mappings so multi versions are right near their bitcask counterparts

Requires:

  • Eng +1
  • CSE +1
  • ProdMgmt +1

Joe DeVivo added 3 commits February 11, 2014 09:26
@gburd
Copy link

gburd commented Feb 12, 2014

PM +1

@jmshoffs0812
Copy link

CSE +1

]}.

%% @see bitcask.open_timeout
{mapping, "multi_backend.$name.bitcask.open_timeout", "riak_kv.multi_backend", [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these multi_backend items suddenly reappear? Are they not in riak_kv?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, saw the commit message. Are we sure they are not in kv's multi_backend.schema as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. This is ok. Ignore the crazy man.

@seancribbs
Copy link
Contributor

Eng +1

joedevivo added a commit that referenced this pull request Feb 13, 2014
Cuttlefish schema RHS sub for platform_bin_dir
@joedevivo joedevivo merged commit 5ff44fc into develop Feb 13, 2014
@joedevivo joedevivo deleted the jd-rhs branch February 13, 2014 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants