Refactor bitcask_fileops:fold_keys function #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor bitcask_fileops:fold_keys to remove nested case statements and improve the clarity. Also change the has_valid_hintfile function to only check for a valid hintfile and not also check for the existence of a hintfile. This change has the side effect of preventing the logging of error messages about invalid hintfiles when the case is just that no hintfile exists.
|
The PR as-is has 4 EUnit test failures (majority are cuttlefish), but they all go away when merged with master. The PULSE test also succeeds for 10 minutes worth of run. +1. I'm gonna hit the merge button, yell at me if I shouldn't've. |
slfritchie
added a commit
that referenced
this pull request
Dec 12, 2013
Refactor bitcask_fileops:fold_keys function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor bitcask_fileops:fold_keys to remove nested case statements and
improve the clarity. Also change the has_valid_hintfile function to only check
for a valid hintfile and not also check for the existence of a hintfile. This
change has the side effect of preventing the logging of error messages about
invalid hintfiles when the case is just that no hintfile exists.