Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: album details #129

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

improve: album details #129

wants to merge 4 commits into from

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Feb 8, 2025

This PR:

  • adds a close button
  • hides the details when the album isn't in the search result

@basharovV
Copy link
Owner

I tried this, there's an issue when closing the details, it leaves an empty space
image

@daiyam
Copy link
Contributor Author

daiyam commented Feb 19, 2025

I tried this, there's an issue when closing the details, it leaves an empty space

It's fixed.
I must have tested on the first row... before trying to fix the issue with the search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daiyam @basharovV