Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAINT #183

Merged
merged 9 commits into from
Dec 11, 2024
Merged

SAINT #183

merged 9 commits into from
Dec 11, 2024

Conversation

AnFreTh
Copy link
Collaborator

@AnFreTh AnFreTh commented Dec 9, 2024

This pull request includes two additions/changes:

  • The inclusion of SAINT in base_models/saint.py
    • tThe core architecture is included in the RowcolTransformer in arch_utils/transformer_utils.py
  • A change in documentation. The docs for models/ are now created from the configs/model_config.py files and the preprocessor config. Thus only the docstrings for the configs must be maintained and implemented.

mkumar73
mkumar73 reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@mkumar73 mkumar73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnFreTh,
The changes looks good to me. Super :)

@mkumar73 mkumar73 merged commit 7dcc086 into develop Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumar73 mkumar73 mkumar73 left review comments

Assignees

@mkumar73 mkumar73

@ChrisW09 ChrisW09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnFreTh @mkumar73 @ChrisW09