rewrite filter logic #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederik-sandfort1
added a commit
that referenced
this pull request
Oct 14, 2024
* remove unnecessary inits and refactor * include smarts filter, smiles filter, descriptors filter * Fix wrong typing that caused thousands of type ignores * linting and fix element number test * reset name typing * Christians first review * more changes * linting * pylint * rewrite filter logic (#71) * Combine filters with one base logic * change dict to Mapping * isort * Include comments * linting * linting and ComplexFilter * typing, tests, complex filter naming * finalize filter refactoring * review Christian * pylint * include check for failed patterns in init * final review * final linting * final final linting * final final final linting --------- Co-authored-by: Christian W. Feldmann <128160984+c-w-feldmann@users.noreply.github.com> Co-authored-by: Christian Feldmann <christian-wolfgang.feldmann@basf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.