Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/mol2concatinated_vector: changes for xai #33

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

JochenSiegWork
Copy link
Collaborator

This PR provides some new utils functionality for automatically extracting specific subpipelines from a given Pipeline and added additional functions to mol2concatinated_vector

@JochenSiegWork JochenSiegWork self-assigned this Jun 27, 2024
@JochenSiegWork
Copy link
Collaborator Author

tests fail because of a bug in the current RDKit pypi version. However, the bug is fixed in the newest RDKit version and we are waiting for the version bump pypi. See kuelumbus/rdkit-pypi#100 for details.

@JochenSiegWork JochenSiegWork force-pushed the code_changes_for_xai branch from f548ac2 to 0a02cda Compare July 3, 2024 15:42
Copy link
Collaborator

@c-w-feldmann c-w-feldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinks which came to my mind during the first read.

molpipeline/utils/subpipeline.py Outdated Show resolved Hide resolved
molpipeline/utils/subpipeline.py Outdated Show resolved Hide resolved
molpipeline/utils/subpipeline.py Show resolved Hide resolved
    - Add helper class SubpipelineExtractor to get certain
      parts of an existing Pipeline.
    - Add property to mol2concatinated_vector to extract
      total number of features.
@JochenSiegWork JochenSiegWork force-pushed the code_changes_for_xai branch from 0a02cda to 93b35b0 Compare July 5, 2024 09:20
@JochenSiegWork JochenSiegWork merged commit 72d5460 into main Jul 5, 2024
14 checks passed
@JochenSiegWork JochenSiegWork deleted the code_changes_for_xai branch July 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants