linting

molpipeline/mol2any/mol2concatinated_vector.py

@@ -96,15 +96,16 @@ def n_features(self) -> int:
     @property
     def feature_names(self) -> list[str]:
         """Return the feature names of concatenated elements."""
-        if self._feature_names_prefix is None:
-            # use element name as prefix
-            prefix_function = lambda elem_name: elem_name
-        else:
-            prefix_function = lambda elem_name: f"{self._feature_names_prefix}"
         feature_names = []
         for name, element in self._element_list:
+            if self._feature_names_prefix is None:
+                # use element name as prefix
+                prefix = name
+            else:
+                # use user specified prefix
+                prefix = self._feature_names_prefix
+
             if hasattr(element, "feature_names"):
-                prefix = prefix_function(name)
                 feature_names.extend(
                     [f"{prefix}__{feature}" for feature in element.feature_names]
                 )

tests/test_elements/test_mol2any/test_mol2concatenated.py

@@ -137,7 +137,7 @@ def test_n_features(self) -> None:
             net_charge_elem[1].n_features + 16 + physchem_elem[1].n_features,
         )
 
-    def test_features_names(self) -> None:
+    def test_features_names(self) -> None:  # pylint: disable=too-many-arguments
         """Test getting the names of features in the concatenated vector."""
 
         physchem_elem = (
@@ -170,7 +170,7 @@ def test_features_names(self) -> None:
 
             for elements_subset in powerset:
                 conc_elem = MolToConcatenatedVector(
-                    elements_subset, feature_names_prefix=feature_names_prefix
+                    list(elements_subset), feature_names_prefix=feature_names_prefix
                 )
                 feature_names = conc_elem.feature_names
 
@@ -182,6 +182,7 @@ def test_features_names(self) -> None:
 
                 seen_names = 0
                 for elem_name, elem in elements_subset:
+                    self.assertTrue(hasattr(elem, "feature_names"))
                     elem_feature_names = elem.feature_names
                     elem_n_features = len(elem_feature_names)
                     relevant_names = feature_names[