Ignore all module-info classes #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module-info classes can be stored in subdirectories, which makes them appear with packages in the duplicate analysis. An example of this is Byte Buddy 1.9.3, which ships META-INF/versions/9/module-info.class in both byte-buddy and byte-buddy-agent. This patch ignores module-info classes anywhere. This fixes #33. Signed-off-by: Stephen Kitt <skitt@redhat.com>
|
This is actually a bit trickier, because what you see is just a symptom and not the cause. The cause is the new multi-release jar format that was introduced as part of Java 9. The plugin needs to learn about this format (and treat the pieces in the jar that are located in META-INF/versions/ the same as other resources on the classpath. I have this as a TODO (as we are moving beyond Java 8 at $WORK as well), so I want to add a more comprehensive fix than just another exclusion pattern. |
|
Yes, of course, and a more comprehensive fix would be very welcome ;-). I was hoping for a quick fix so we could remove our own exclusions, but you’re the maintainer! I’ll delete my PR in a little while, unless you’d rather I didn’t. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module-info classes can be stored in subdirectories, which makes them
appear with packages in the duplicate analysis. An example of this is
Byte Buddy 1.9.3, which ships META-INF/versions/9/module-info.class in
both byte-buddy and byte-buddy-agent.
This patch ignores module-info classes anywhere. This fixes #33.
Signed-off-by: Stephen Kitt skitt@redhat.com