Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Java 9's module-info classes by default #31

Closed
bclozel opened this issue Jan 2, 2018 · 4 comments
Closed

Ignore Java 9's module-info classes by default #31

bclozel opened this issue Jan 2, 2018 · 4 comments
Assignees

Comments

@bclozel
Copy link

bclozel commented Jan 2, 2018

It is easy to configure this plugin to ignore duplicate module-info.class classes with the following:

<configuration>
  <ignoredClassPatterns>
    <ignoredClassPattern>module-info</ignoredClassPattern>
  </ignoredClassPatterns>
</configuration>

Since those classes might be quite common in the future, shouldn't this be ignored by default?
Otherwise, those are marked as duplicate classes with different content.

@hgschmie hgschmie self-assigned this Feb 18, 2018
hgschmie pushed a commit that referenced this issue Feb 18, 2018
@hgschmie
Copy link
Contributor

will be in 1.3.0

@whiskeysierra
Copy link

I see a similar issue now with /META-INF/versions/9/module-info.class

@whiskeysierra
Copy link

@bclozel
Copy link
Author

bclozel commented Oct 31, 2018

@whiskeysierra Yes, see spring-projects/spring-boot@c82a13d

@hgschmie should we open a new issue or reopen this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants