Fixes and remove glide dependency #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-borgmann
requested review from
aheartforspinach,
mloeffle and
jkniest
as code owners
| @@ -17,6 +17,7 @@ productListingCriteriaStore.initializeCriteria( | |||
| children: {}, | |||
| manufacturer: {}, | |||
| options: {}, | |||
| media: {}, | |||
There was a problem hiding this comment.
Could we add an includes here to prevent loading data which we don't need?
There was a problem hiding this comment.
We should definitely do that in the future. Right now I think since we are still heavily in development its easier to load all and then later make it more specific once it is clearer which of the data we need.
adnansaadeddine
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes and removed dependency on glide