Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add NAME=all option for accessory reboot #550

Merged

Conversation

dmitrytrager
Copy link
Contributor

This missing cli option was discusses within the issue

@dmitrytrager dmitrytrager marked this pull request as ready for review October 29, 2023 10:16
@djmb
Copy link
Collaborator

djmb commented Oct 30, 2023

Thanks for the PR @dmitrytrager!

Could you add a test for this? There's a similar one in test/cli/accessory_test.rb for boot all.

@dmitrytrager
Copy link
Contributor Author

Sure, will do

@dmitrytrager dmitrytrager force-pushed the feature-name-all-for-accessory-reboot branch from d0b336d to 2d22143 Compare October 30, 2023 23:13
@dmitrytrager
Copy link
Contributor Author

@djmb updated

@djmb djmb merged commit 1152151 into basecamp:main Nov 16, 2023
6 checks passed
@dmitrytrager dmitrytrager deleted the feature-name-all-for-accessory-reboot branch November 16, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants