-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate deploy.yaml with json-schema #37
Conversation
I like where this is going. |
41e2bcb
to
6a7fabd
Compare
6a7fabd
to
dfa8ac8
Compare
I dig this. The error messages aren't super friendly out the box, but it's better than what we have now: which is half baked! Please do continue 👍 |
165db58
to
c4fb0ec
Compare
f0a468a
to
57a772a
Compare
I'd appreciate some feedback here. I think I've covered all configuration options but there may be cases I've missed. For example I just discovered in one of my projects that Therefore, I'd appreciate if you could try to run my patch with your current working configurations and tell me how it works. It passes all tests, test fixtures and the examples in README.md. It doesn't break if new config options are introduced, just that they wont be validated until added in the schema. So, I think this is ready to merge. Would be nice to have the schema merged into the repo, so we can keep it synced with new features and patches. I'm ready to assist should errors occur. |
Awesome. Will check it out now. Yes, we just had an issue this morning at 37s because of lacking schema validation 😄 |
What can we do to improve the error messages? They're really quite rough right now. Like if I change "servers" to "server", I get: |
If I change builder/args to builder/arguments, it doesn't complain. Is there a way to make a list of properties exhaustive? |
Think we might need some more exhaustive testing. |
Note to users: While you are waiting for this and using VS Code,
|
Hello! Are there currently any plans for a JSON schema for Kamal, whether from this PR or any other source, to be available in Rails 8.0 or any subsequent releases? I see there hasn't been any activity for quite some time. |
Superseded by #828 |
A suggestion to #6 - catch errors in deploy.yaml better.
lib/configuration/schema.yaml
sets json-schema rules fordeploy.yaml
.Must be extended with validations for all available options, just want to hear your opinion first.
Example 1
Example 2