Login to the registry proactively before stoping Accessory and Traefik #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmb
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Thanks for this @igor-alexandrov! Agreed that this is important to fix.
Could you fix the issue I mentioned and then I'll get this merged?
djmb
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
mrsk traefik rebootandmrsk accessory rebootfirst do stop and only at the end of the script attempt to log in to the registry. If the login fails (e.g., due to an expiredMRSK_REGISTRY_PASSWORD), Traefik or the accessory will remain stopped.I have changed the order of commands performed during the reboot. Now, if the login fails, Traefik and the accessory will continue running.