Allow ssh/config to accept string, or array of strings
#1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgestrand
force-pushed
the
kbs/allow-ssh_options-in-ssh-config
branch
from
703e19b
to
14cde2c
Compare
This option is documented as available since basecamp#908 in: https://github.com/basecamp/kamal/blob/74a06b0ccda616c86ebe1729d0795f39bcac9f00/lib/kamal/configuration/docs/ssh.yml#L65-L70 However, before this the options don't seem to pass through to SSHKit: https://github.com/basecamp/kamal/blob/74a06b0ccda616c86ebe1729d0795f39bcac9f00/lib/kamal/commander.rb#L167 Since `config` isn't actually returned in `#options`.
…rings This is accepted by Net::SSH, research done by @jeremy in basecamp#908 (comment) This is already documented as working correctly in https://github.com/basecamp/kamal/blob/74a06b0ccda616c86ebe1729d0795f39bcac9f00/lib/kamal/configuration/docs/ssh.yml#L65-L70 However, before this change only booleans were allowed because of the example configuration file.
Burgestrand
force-pushed
the
kbs/allow-ssh_options-in-ssh-config
branch
from
14cde2c
to
7abd339
Compare
|
FYI I force-pushed, because I added tests to each commit. |
|
I've noticed that certain commands (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I made this PR rogue, in the sense that I forked and made a change that seems to have worked without discussing this change with anybody else first. I don't necessarily expect this to be merged. 🙂
On the topic of passing through
configI would like to use this option, so that I can embed aconfig/ssh_configwith my project and have Kamal use it, instead of having to modify my global~/.ssh/config.There are two changes in this PR:
ssh/configthrough to the SSH options, so that the documentation is accurate.The second change allows passing the path to an
ssh_config-file, similar to this one:... which then allows you to specify the hosts using the names, rather than IPs. The same file can also be used when SSHing in manually, using
ssh -F ssh_config web.This is reviewable commit-by-commit.
To do