Follow logs on primary role by default #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not default `kamal app logs -f` to use the hardcoded “web” role; instead use the primary role, which can be different from “web”.
jeromedalbert
force-pushed
the
follow-primary-role
branch
from
fc95f1a
to
f47fd13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
kamal app logs -fdoesn't work if the primary role is not "web".Steps to repro:
primary_role: workerinconfig/deploy.ymlkamal app logs -fActual behavior:
Expected behavior:
kamal app logs -fshould not error out.Solution
Do not default
kamal app logs -fto use the hardcoded "web" role; instead use the primary role, which can be different from "web".