Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv gem to gemspec #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidarendsen
Copy link

Got a warning that csv will no longer be part of the default gems since Ruby 3.4.0.
So this needs to be added in the gemspec.

@rafbm
Copy link

rafbm commented Nov 26, 2024

It seems CSV is only used for a one-time parse of digits.csv which looks like it could easily be converted to YAML. Would there be interest in such conversion to avoid the CSV dependency?

@davidarendsen
Copy link
Author

I could convert it to a YAML file and make that work.
However I see that the CSV's content was generated by a script that I don't see in the repository. So not sure how often this would change. When a change is required that script should also be changed.

# Built with script/development/generate_digits_characters.rb
def read_digits
  File.read("#{__dir__}/data/digits.csv")
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants