Skip to content

Commit

Permalink
Enable -Wimplicit-retain-self en sync warning config for all projects
Browse files Browse the repository at this point in the history
Summary:
This is enforced for all of our internal iOS code and a common cause of import failures.

cc janicduplessis
Closes facebook/react-native#13124

Differential Revision: D4765016

fbshipit-source-id: 7c8248c98bca0fa6bad24d5a52b666243375e0db
  • Loading branch information
javache authored and facebook-github-bot committed Mar 23, 2017
1 parent b969313 commit 8c2da62
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions RCTCameraRoll.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Expand Down Expand Up @@ -200,6 +201,7 @@
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Expand Down

0 comments on commit 8c2da62

Please sign in to comment.