Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the npm API's error handling and test coverage #2225

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Nov 27, 2024

This fixes #2224

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code labels Nov 27, 2024
@bartfeenstra bartfeenstra added this to the 0.4.x milestone Nov 27, 2024
@bartfeenstra bartfeenstra changed the title Improve test coverage of the npm API Improve the npm API's error handling and test coverage Nov 27, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review November 27, 2024 11:29
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (1247b5c) to head (431e008).
Report is 1 commits behind head on 0.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #2225      +/-   ##
==========================================
+ Coverage   98.21%   98.22%   +0.01%     
==========================================
  Files         365      365              
  Lines       23165    23187      +22     
  Branches     1069     1069              
==========================================
+ Hits        22751    22775      +24     
+ Misses        266      264       -2     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 9f31102 into 0.4.x Nov 27, 2024
8 checks passed
@bartfeenstra bartfeenstra deleted the improve-npm-test branch November 27, 2024 11:55
@bartfeenstra bartfeenstra added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NpmRequirement object has no attribute _summary
1 participant