Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new theme: Raspberry Mint #2192

Draft
wants to merge 1 commit into
base: 0.4.x
Choose a base branch
from
Draft

Add a new theme: Raspberry Mint #2192

wants to merge 1 commit into from

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Nov 4, 2024

This fixes #908

Demo

https://bartfeenstra.github.io/betty

Blocked by

To do

  • FileReference.focus does not work for non-bitmap images #2133
  • A html_lang_attrs Jinja2 filter built on top of generic Jinja2 HTML attribute handling. This has priority so we remember to apply this in all our new templates. Use on <html> as well.
  • web app manifest (https://en.wikipedia.org/wiki/Progressive_web_app#Manifest)
  • font
    • support for as many writing scripts as possible
    • can we determine which scripts we need? Probably not, with so many translatable and localized fields everywhere in config as well as the ancestry
    • install using npm, and self-host
  • Components:
    • header
      • search
    • event timeline: can we include non-comparable events?
  • search results
  • Render place types
  • Render genders
  • right-to-left support
  • Pages
    • front page
    • place listing (with map)
    • place
    • person
    • file
    • event
    • source
    • citation

Goals

  • accessibility compliance
  • keyboard navigation
  • reusable components as Jinja2 template files
  • Configurable colors
  • Configurable icons
  • right-to-left support

@bartfeenstra bartfeenstra added enhancement New feature or request javascript Pull requests that update Javascript code ux User Experience templating Jinja2 templating a11y Accessibility html HTML css CSS labels Nov 4, 2024
@bartfeenstra bartfeenstra added this to the 0.4.x milestone Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 98.69281% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.22%. Comparing base (5cc02f2) to head (413ffed).

Files with missing lines Patch % Lines
betty/project/extension/_theme.py 97.20% 1 Missing and 3 partials ⚠️
.../project/extension/raspberry_mint/test___init__.py 95.34% 1 Missing and 1 partial ⚠️
betty/tests/project/extension/test__theme.py 98.93% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            0.4.x    #2192    +/-   ##
========================================
  Coverage   98.22%   98.22%            
========================================
  Files         365      371     +6     
  Lines       23209    23480   +271     
  Branches     1071     1072     +1     
========================================
+ Hits        22797    23064   +267     
- Misses        264      266     +2     
- Partials      148      150     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
"""
Common theme functionality.

The contents of this file should eventually be stabilized and moved to more specific modules.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorganize the module contents

@bartfeenstra bartfeenstra force-pushed the raspberry-mint branch 14 times, most recently from b08f445 to e44a5e6 Compare December 16, 2024 21:22
@bartfeenstra bartfeenstra force-pushed the raspberry-mint branch 4 times, most recently from 12f14e8 to 079b762 Compare December 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility css CSS enhancement New feature or request html HTML javascript Pull requests that update Javascript code templating Jinja2 templating ux User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new theme
1 participant