Fix a bug where PyInstaller builds would not include all data files #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartfeenstra
added
bug
bartfeenstra
force-pushed
the
fix-pyinstaller-missing-assets
branch
from
2ba773e to
172308b
Compare
bartfeenstra
force-pushed
the
fix-pyinstaller-missing-assets
branch
from
172308b to
63a7a35
Compare
|
Uploaded Betty for commit 63a7a35. You can download it, test it, and post your feedback in a comment to this pull request 💕 These downloads will stop working when the pull request is closed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.3.x #1814 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 200 200
Lines 19252 19252
Branches 3664 3664
=======================================
Hits 18390 18390
Misses 593 593
Partials 269 269 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1734