Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a test mock that went out of sync after a recent commit #1612

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

bartfeenstra
Copy link
Owner

Fix a test mock that went out of sync after a recent commit, and that would erroneously allow a server to be started and a browser window to be opened

… would erroneously allow a server to be started and a browser window to be opened
@bartfeenstra bartfeenstra added bug Something isn't working python Pull requests that update Python code labels Jun 24, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review June 24, 2024 14:31
@bartfeenstra bartfeenstra merged commit 2109afc into 0.4.x Jun 24, 2024
8 of 9 checks passed
@bartfeenstra bartfeenstra deleted the fix-mock-test-cli-test-serve branch June 24, 2024 17:44
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (d68b3c0) to head (a41cf03).
Report is 319 commits behind head on 0.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #1612      +/-   ##
==========================================
- Coverage   95.71%   95.69%   -0.02%     
==========================================
  Files         198      198              
  Lines       18762    18761       -1     
  Branches     3569     3569              
==========================================
- Hits        17958    17954       -4     
- Misses        546      548       +2     
- Partials      258      259       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant