Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove server negotiation #1587

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Remove server negotiation #1587

merged 1 commit into from
Jun 21, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1142

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Jun 21, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review June 21, 2024 17:11
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit ea03ae6. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the remove-server-negotiation branch from ea03ae6 to 2bff382 Compare June 21, 2024 17:46
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit 2bff382. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the remove-server-negotiation branch from 2bff382 to c49a86c Compare June 21, 2024 18:55
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit c49a86c. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the remove-server-negotiation branch from c49a86c to ab5a301 Compare June 21, 2024 19:26
@github-actions GitHub Actions
Copy link

Uploaded Betty for commit ab5a301. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit 9664d5f into 0.4.x Jun 21, 2024
9 checks passed
@bartfeenstra bartfeenstra deleted the remove-server-negotiation branch June 21, 2024 19:54
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (2cdb4ab) to head (ab5a301).
Report is 313 commits behind head on 0.4.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##            0.4.x    #1587      +/-   ##
==========================================
+ Coverage   95.59%   95.62%   +0.03%     
==========================================
  Files         198      198              
  Lines       19010    18986      -24     
  Branches     3618     3608      -10     
==========================================
- Hits        18172    18156      -16     
+ Misses        572      566       -6     
+ Partials      266      264       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove server negotiation
1 participant
@bartfeenstra