Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a newly missing Qt dependency when building setuptools/PyPI releases #1552

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1550

@bartfeenstra bartfeenstra added bug Something isn't working python Pull requests that update Python code labels Jun 8, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review June 8, 2024 20:03
Copy link

github-actions bot commented Jun 8, 2024

Uploaded Betty for commit 2db60b7. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (3630350) to head (2db60b7).
Report is 37 commits behind head on 0.3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1552      +/-   ##
==========================================
- Coverage   95.55%   95.54%   -0.02%     
==========================================
  Files         199      199              
  Lines       19131    19131              
  Branches     3643     3643              
==========================================
- Hits        18281    18278       -3     
- Misses        581      584       +3     
  Partials      269      269              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 4330314 into 0.3.x Jun 8, 2024
10 of 11 checks passed
@bartfeenstra bartfeenstra deleted the fix-missing-qt-dependency-setuptools-release branch June 8, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.3.6 setuptools build failed
1 participant