Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Wikipedia extension's functionality to download images configurable #1481

Merged
merged 1 commit into from
May 8, 2024

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented May 8, 2024

This allows site owners to disable a potentially very slow (because lots of work to do) feature, and lays the groundwork for #1478

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code ux User Experience labels May 8, 2024
@bartfeenstra bartfeenstra added this to the 0.3.x milestone May 8, 2024
@bartfeenstra bartfeenstra force-pushed the wikipedia-config-toggle-populate-images branch from c82ec1d to 0ec1607 Compare May 8, 2024 16:59
@bartfeenstra bartfeenstra marked this pull request as ready for review May 8, 2024 16:59
Copy link

github-actions bot commented May 8, 2024

Uploaded Betty for commit 0ec1607. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.73%. Comparing base (04410b4) to head (0ec1607).

Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1481      +/-   ##
==========================================
+ Coverage   93.70%   93.73%   +0.03%     
==========================================
  Files          95       97       +2     
  Lines        9731     9791      +60     
==========================================
+ Hits         9118     9178      +60     
  Misses        613      613              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 7e8ba5c into 0.3.x May 8, 2024
11 checks passed
@bartfeenstra bartfeenstra deleted the wikipedia-config-toggle-populate-images branch May 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code ux User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant