Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting in the Graphical User Interface #1292

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

bartfeenstra
Copy link
Owner

No description provided.

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations labels Feb 20, 2024
@bartfeenstra bartfeenstra added this to the 0.3.0 milestone Feb 20, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review February 20, 2024 23:52
Copy link

Uploaded Betty for commit 60f0a2f. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 6c406a6. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 07c65ed. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 64589bb. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 23355d7. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 0e582a9. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 9103fde. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 41450f8. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit f0ef6bb. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 1619250. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 513f295. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the gui-error-windows branch 2 times, most recently from 525e4e6 to 321abb8 Compare February 21, 2024 18:22
Copy link

Uploaded Betty for commit 525e4e6. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 321abb8. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/error.py Outdated Show resolved Hide resolved
@bartfeenstra bartfeenstra force-pushed the gui-error-windows branch 2 times, most recently from b793968 to 2b11bd9 Compare February 21, 2024 19:17
Copy link

Uploaded Betty for commit 2b11bd9. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit b793968. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the gui-error-windows branch 2 times, most recently from 3d449b7 to 5149fb0 Compare February 22, 2024 17:23
Copy link

Uploaded Betty for commit 5149fb0. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/gui/error.py Outdated Show resolved Hide resolved
@bartfeenstra bartfeenstra marked this pull request as draft February 22, 2024 17:46
Copy link

Uploaded Betty for commit bcf8986. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit f9d0685. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 1103456. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra marked this pull request as ready for review February 23, 2024 21:56
Copy link

Uploaded Betty for commit 2e453b3. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra marked this pull request as draft February 24, 2024 00:55
Copy link

Uploaded Betty for commit 6d82983. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit a427305. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 92.19%. Comparing base (e08e13c) to head (a427305).

Files Patch % Lines
betty/gui/error.py 75.55% 11 Missing ⚠️
betty/gui/text.py 42.85% 4 Missing ⚠️
betty/gui/__init__.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1292      +/-   ##
==========================================
- Coverage   92.37%   92.19%   -0.19%     
==========================================
  Files          81       81              
  Lines        9041     9069      +28     
==========================================
+ Hits         8352     8361       +9     
- Misses        689      708      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra marked this pull request as ready for review February 24, 2024 15:46
@bartfeenstra bartfeenstra merged commit 6a58b5b into 0.3.x Feb 24, 2024
9 of 11 checks passed
@bartfeenstra bartfeenstra deleted the gui-error-windows branch February 24, 2024 15:47
@bartfeenstra bartfeenstra linked an issue Feb 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site generation in the Graphical User Interface is broken
1 participant