Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove php parser #1644

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Remove php parser #1644

merged 2 commits into from
Dec 30, 2024

Conversation

barryvdh
Copy link
Owner

Summary

Remove the PHP Parser. It was only used in edge-cases. The ContextFactory can be used to get the class aliases, similar to it being used in the rest of the code.
Only the realtime facades are using the php-parser besides that, and those are always the same format in the stubs, so just as well just regex them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh barryvdh merged commit 9c6380d into master Dec 30, 2024
17 checks passed
@barryvdh barryvdh deleted the feat-remove-parser branch December 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant