Fix issue with MonologCollector collector for Laravel >= v5.6 #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging was refactored in Laravel 5.6. `getMonolog()` method does not exist on a new Illuminate\Log\Logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue if you set
debugbar.collectors.messages => falseanddebugbar.collectors.log => true. The problem occurs because logging was refactored in Laravel 5.6 andgetMonolog()method does not exist on a newIlluminate\Log\Logger(PR: laravel/framework#22635). Related issue: #972This PR solves this problem for Laravel versions 5.6, 5.7 and 5.8.
However the problem with Laravel 6.0 still exists, if
monolog/monolog ^2.0is used, because the method signature was changed inAbstractProcessingHandlerandmaximebf/php-debugbardoes not support it yet.(https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/AbstractProcessingHandler.php#L50). There is an open PR for this issue: php-debugbar/php-debugbar#427. However, this issue with Laravel 6.x maybe could be solved in a separate PR.