Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AWS provider required version #41

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Bump AWS provider required version #41

merged 1 commit into from
Aug 31, 2023

Conversation

renegaderyu
Copy link
Contributor

Summary

Change aws required_providers version from >= 3.50 to >= 4.23

Description

The aws_elasticache_replication_group resource uses description and num_cache_clusters args for all new provider versions since 4.23. See https://registry.terraform.io/providers/hashicorp/aws/4.23.0/docs/resources/elasticache_replication_group. Prior to this there were mised uses of number_cache_clusters and replication_group_description. Even though the version requirement wasversion = ">= 3.50", it seems the module was built and tested w/ 4.46.

Type of change

  • Bug fix

How Has This Been Tested?

I'm in the process of testing rollout of some cga proxies w/ our IT team.

Theses changes have been tested in:

  • Local environment
  • Development environment
  • Staging environment
  • Production environment

Checklist

  • Fill the description
  • Declare the type of changes included in the pull request
  • Describe how has this been tested
  • Add categorical labels (feature/fix/chore/docs/skip-changelog)
  • Add semver labels (patch/minor/major/skip-semver)

Sorry, something went wrong.

@renegaderyu
Copy link
Contributor Author

Another option is to segment branches/versions of this module for use with different AWS providers; though this would cause more overhead for the CGA team to maintain.

@renegaderyu
Copy link
Contributor Author

renegaderyu commented Aug 10, 2023

@Evilong Another thing is that validation of the proxy tokens seems to fail because the expectation that proxy_auth_token= occurs in the string; However, new tokens generated by our IT dept. do not have this. I've added a commit to address this as well.

Edit: it seems the tokens were truncated by the communication mechanism. I've received new tokens that match the regex so I've removed that commit from this branch/PR.

@joaoestrela joaoestrela marked this pull request as ready for review August 31, 2023 08:52
@joaoestrela joaoestrela requested a review from a team as a code owner August 31, 2023 08:52
@joaoestrela joaoestrela added patch and removed patch labels Aug 31, 2023
@joaoestrela joaoestrela merged commit c1cfd59 into barracuda-cloudgen-access:main Aug 31, 2023
@renegaderyu renegaderyu deleted the deploymnet-test branch September 20, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants