Merge pull request #15 from barracuda-cloudgen-access/add-missing-config

Add missing config
barracuda-cloudgen-access · Feb 10, 2022 · d99f395 · d99f395
2 parents f96cf3f + 27e4ab8
commit d99f395
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Change Log
 
+## v1.2.4
+
+- [aws-asg] Add missing key for metadata on launch config
+- [aws-asg] Add description for security group rule
+
+## v1.2.3
+
+- [aws-asg] Remove aws provider from the module and update examples
+- Update actions
+
 ## v1.2.2
 
 - [aws-asg] Limit outbound to resource group.

diff --git a/modules/aws-asg/README.md b/modules/aws-asg/README.md
@@ -68,7 +68,7 @@ No modules.
 | <a name="input_launch_cfg_associate_public_ip_address"></a> [launch\_cfg\_associate\_public\_ip\_address](#input\_launch\_cfg\_associate\_public\_ip\_address) | Associate a public ip address with an instance in a VPC | `bool` | `false` | no |
 | <a name="input_launch_cfg_instance_type"></a> [launch\_cfg\_instance\_type](#input\_launch\_cfg\_instance\_type) | The type of instance to use (e.g. t2.micro, t2.small, t2.medium, etc) | `string` | `"t2.small"` | no |
 | <a name="input_launch_cfg_key_pair_name"></a> [launch\_cfg\_key\_pair\_name](#input\_launch\_cfg\_key\_pair\_name) | The name of the key pair to use | `string` | n/a | yes |
-| <a name="input_module_version"></a> [module\_version](#input\_module\_version) | Terraform module version | `string` | `"v1.2.2"` | no |
+| <a name="input_module_version"></a> [module\_version](#input\_module\_version) | Terraform module version | `string` | `"v1.2.4"` | no |
 | <a name="input_nlb_enable_cross_zone_load_balancing"></a> [nlb\_enable\_cross\_zone\_load\_balancing](#input\_nlb\_enable\_cross\_zone\_load\_balancing) | Configure cross zone load balancing for the NLB | `bool` | `false` | no |
 | <a name="input_nlb_subnets"></a> [nlb\_subnets](#input\_nlb\_subnets) | A list of public subnet IDs to attach to the LB. Use Public Subnets only | `list(string)` | n/a | yes |
 | <a name="input_redis_subnets"></a> [redis\_subnets](#input\_redis\_subnets) | A list of subnet IDs to to use for the redis instances.<br>  At least two subnets on different Availability Zones must be provided | `list(any)` | `[]` | no |

diff --git a/modules/aws-asg/examples/cga-with-vpc/README.md b/modules/aws-asg/examples/cga-with-vpc/README.md
@@ -13,7 +13,7 @@ No requirements.
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_cloudgen-access-proxy"></a> [cloudgen-access-proxy](#module\_cloudgen-access-proxy) | git::git@github.com:barracuda-cloudgen-access/terraform-modules.git//modules/aws-asg | v1.2.2 |
+| <a name="module_cloudgen-access-proxy"></a> [cloudgen-access-proxy](#module\_cloudgen-access-proxy) | git::git@github.com:barracuda-cloudgen-access/terraform-modules.git//modules/aws-asg | v1.2.4 |
 | <a name="module_key_pair"></a> [key\_pair](#module\_key\_pair) | terraform-aws-modules/key-pair/aws | 1.0.0 |
 | <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | 3.0.0 |
 

diff --git a/modules/aws-asg/main.tf b/modules/aws-asg/main.tf
@@ -100,6 +100,7 @@ resource "aws_security_group" "inbound" {
   }
 
   egress {
+    description = "Allow outbound to all"
     from_port   = 0
     to_port     = 0
     protocol    = "-1"
@@ -239,7 +240,8 @@ resource "aws_launch_configuration" "launch_config" {
   name_prefix                 = "cga-proxy-${random_string.prefix.result}-"
 
   metadata_options {
-    http_tokens = "required"
+    http_endpoint = "enabled"
+    http_tokens   = "required"
   }
 
   security_groups = compact([

diff --git a/modules/aws-asg/variables.tf b/modules/aws-asg/variables.tf
@@ -44,7 +44,7 @@ variable "cloudgen_access_proxy_level" {
 variable "module_version" {
   description = "Terraform module version"
   type        = string
-  default     = "v1.2.2"
+  default     = "v1.2.4"
 }
 
 #