Remove aws provider from the module and update examples

README.md

@@ -15,7 +15,9 @@ Check the [Product Documentation](https://campus.barracuda.com/product/cloudgena
 ## Misc
 
 - This repository has [pre-commit](https://github.com/antonbabenko/pre-commit-terraform) configured
-  - Test all the pre-commit hooks with `pre-commit run -a`
+  - Test all the pre-commit hooks with:
+    - `docker run -v $(pwd):/lint -w /lint ghcr.io/antonbabenko/pre-commit-terraform:latest run -a`
+    - Cleanup, in case of plugin issues: `find . -name ".terraform*" -print0 | xargs -0 rm -r`
 - Test github actions with [nektos/act](https://github.com/nektos/act)
 
 ## Links

modules/aws-asg/README.md

@@ -79,3 +79,4 @@ No modules.
 | Name | Description |
 |------|-------------|
 | <a name="output_Network_Load_Balancer_DNS_Name"></a> [Network\_Load\_Balancer\_DNS\_Name](#output\_Network\_Load\_Balancer\_DNS\_Name) | Update the CloudGen Access Proxy in the Console with this DNS name |
+| <a name="output_Security_Group_for_Resources"></a> [Security\_Group\_for\_Resources](#output\_Security\_Group\_for\_Resources) | Use this group to allow CloudGen Access Proxy access to internal resources |

modules/aws-asg/examples/README.md → modules/aws-asg/examples/cga-with-vpc/README.md

@@ -6,8 +6,8 @@ No requirements.
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | n/a |
-| <a name="provider_tls"></a> [tls](#provider\_tls) | n/a |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 3.74.1 |
+| <a name="provider_tls"></a> [tls](#provider\_tls) | 3.1.0 |
 
 ## Modules
 
@@ -35,3 +35,4 @@ No requirements.
 | Name | Description |
 |------|-------------|
 | <a name="output_Network_Load_Balancer_DNS_Name"></a> [Network\_Load\_Balancer\_DNS\_Name](#output\_Network\_Load\_Balancer\_DNS\_Name) | n/a |
+| <a name="output_Security_Group_for_Resources"></a> [Security\_Group\_for\_Resources](#output\_Security\_Group\_for\_Resources) | n/a |

modules/aws-asg/examples/cga_with_vpc.tf → modules/aws-asg/examples/cga-with-vpc/main.tf

@@ -16,17 +16,24 @@ locals {
 
 provider "aws" {
   region = local.aws_region
+  default_tags {
+    tags = {
+      Owner       = "team"
+      Environment = "test"
+    }
+  }
 }
 
 #
 # CloudGen Access Proxy
 #
 
 module "cloudgen-access-proxy" {
-  source = "git::git@github.com:barracuda-cloudgen-access/terraform-modules.git//modules/aws-asg?ref=v1.2.2"
+  source = "../../"
 
   # More examples
   # run 'rm -rf .terraform/' after changing source
+  # source = "git::git@github.com:barracuda-cloudgen-access/terraform-modules.git//modules/aws-asg?ref=vx.x.x"
   # source = "git::git@github.com:barracuda-cloudgen-access/terraform-modules.git//modules/aws-asg?ref=<branch-name>"
   # source = "../"
 
@@ -51,8 +58,7 @@ module "cloudgen-access-proxy" {
   launch_cfg_key_pair_name = module.key_pair.key_pair_key_name
 
   tags = {
-    Environment = "test"
-    Team        = "awesome"
+    extra_tag = "extra-value"
   }
 }
 
@@ -68,7 +74,7 @@ output "Security_Group_for_Resources" {
 # SSH key for instances
 #
 
-# (!) The private key will be saves in the terraform state file
+# (!) The private key will be saved in the terraform state file
 resource "tls_private_key" "private_key" {
   algorithm = "RSA"
 }
@@ -127,7 +133,7 @@ module "vpc" {
   manage_default_security_group  = true
 
   tags = {
-    environment = local.application
+    extra_tag = "extra-value"
   }
 
   vpc_tags = {
@@ -139,8 +145,7 @@ resource "aws_default_route_table" "default" {
   default_route_table_id = module.vpc.default_route_table_id
 
   tags = {
-    Name        = "${local.application}-default"
-    environment = local.application
-    warning     = "This is created by AWS for the VPC and cannot be removed"
+    Name    = "${local.application}-default"
+    warning = "This is created by AWS for the VPC and cannot be removed"
   }
 }