Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for rspec 3 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansr_dpla/spec/lib/relation/facet_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
fkey = test.facets.keys.first
facet = test.facets[fkey]
expect(facet).to be_a(Ansr::Facets::FacetField)
expect(test.loaded?).to be_false
expect(test.loaded?).to be false
test.facets # make sure we memoized the facet values
end
end
Expand Down
10 changes: 5 additions & 5 deletions ansr_dpla/spec/lib/relation_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def self.table
expect(test2).to be_a(Ansr::Relation)
@mock_api.should_receive(:items).with(:q => 'kittens').and_return('')
test2.load
expect(test.order_values.empty?).to be_false
expect(test.order_values.empty?).to be false
end
# ActiveRecord::QueryMethods.VALID_UNSCOPING_VALUES =>
# Set.new([:where, :select, :group, :order, :lock, :limit, :offset, :joins, :includes, :from, :readonly, :having])
Expand Down Expand Up @@ -222,9 +222,9 @@ def self.table
it 'should be false before and true after' do
test = subject.where(q:'kittens')
@mock_api.stub(:items).with(:q => 'kittens').and_return('')
expect(test.loaded?).to be_false
expect(test.loaded?).to be false
test.load
expect(test.loaded?).to be_true
expect(test.loaded?).to be true
end
end

Expand All @@ -245,8 +245,8 @@ def self.table
test = subject.where(q:'kittens')
@mock_api.should_receive(:items).with(:q => 'kittens').once.and_return(@empty)
test.load
expect(test.loaded?).to be_true
expect(test.empty?).to be_true
expect(test.loaded?).to be true
expect(test.empty?).to be true
end

end
Expand Down