Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

sip: add RFC 3262 support #88

Merged
merged 2 commits into from
Jul 6, 2022
Merged

sip: add RFC 3262 support #88

merged 2 commits into from
Jul 6, 2022

Conversation

maximilianfridrich
Copy link
Contributor

@maximilianfridrich maximilianfridrich commented Jul 5, 2022

Adds tests for RFC 3262.

Related:

@cspiel1 cspiel1 changed the title sipsess: add 100rel tests sip: add RFC 3262 support Jul 6, 2022
@cspiel1
Copy link
Collaborator

cspiel1 commented Jul 6, 2022

I renamed this PR. It needs to have the same name like the re PR.

@cspiel1 cspiel1 merged commit 37091ba into baresip:main Jul 6, 2022
@sreimers
Copy link
Member

sreimers commented Jul 6, 2022

The new tests test_sipsess_100rel_caller_require and test_sipsess_100rel_supported are very slow:

$ time ./retest -r -v test_sipsess_100rel_supported     
single testcase: test_sipsess_100rel_supported
retest: libre version 2.5.0 (x86_64/linux)
using async polling method 'epoll'
using datapath './data'
regular tests:       OK
./retest -r -v test_sipsess_100rel_supported  0,00s user 0,00s system 0% cpu 10,009 total

Looks like they run into the re_main timeout override limit, maybe a re_cancel is missing.
@cspiel1 @maximilianfridrich

@maximilianfridrich
Copy link
Contributor Author

The new tests test_sipsess_100rel_caller_require and test_sipsess_100rel_supported are very slow:

I will look into this shortly.

@maximilianfridrich
Copy link
Contributor Author

@maximilianfridrich maximilianfridrich deleted the rfc_3262 branch July 19, 2022 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants