dns/client: fix rrlv reference cache handling #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not enough to reference `rr` for handle caching, since if the original query is derefed the rr->le_priv->list is derefed too. This can lead to crashes. This PR references the complete rrlv lists for caching.
sreimers
force-pushed
the
dns_client_fix_rrlv
branch
from
9e69ee5 to
d0e501a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not enough to reference
rrfor handle caching, since if the original query is derefed therr->le_priv->listis derefed too. This can lead to heap-use-after-free crashes if list is accessed (like withlist_unlink). This PR references the complete rrlv lists for caching.Fixes baresip/retest#168