sipreg: skip digest challenge for de-register #49
Conversation
src/sipreg/reg.c
Outdated
| sip_auth_reset(reg->auth); | ||
| /* the dialog will stop in case of a de-registration so we | ||
| * must skip the digest challenge */ | ||
| if (!reg->terminated) |
There was a problem hiding this comment.
Previous commit was mine d8cfc30. We checked again if a re-REGISTER should start with a new digest challenge and found that it might not be necessary. We found this examples:
- re-REGISTRATION: https://tools.ietf.org/html/rfc3665#section-2.2
- de-REGISTRATION: https://tools.ietf.org/html/rfc3665#section-2.4
I tested with https://routr.io/ and sip.linphone.org without the sip_auth_reset() call. Then the nonce is reused. The cnonce and the digest response is updated. Would I saw is these SIP proxies accept the re-REGISTER with the old nonce.
Let's suppose that the SIP registrar does not accept the old nonce. Then it will answer with a Status 401 and then we start a new digest challenge. So it would also work.
So we think that line 300 (the call to sip_auth_reset()) should be completely removed. It will reactivate the old behavior before the commit d8cfc30.
There was a problem hiding this comment.
I wouldn't mind that. Should I update the PR?
There was a problem hiding this comment.
I would say yes. We suggest to remove the line completely.
For a re-register an expired nonce will automatically result in 401 anyway, so no need to force that. For a de-register the dialog will be stopped after sending the REGISTER with expires=0 so in case of an 401 response we're out of luck anyway and the server must do its house-keeping.
njeisecke
force-pushed
the
fix_deregister
branch
from
1c1d223 to
ba569ac
Compare
|
Looks good now. |
|
Thanks! |
The dialog will stop after sending the REGISTER with expires=0
(de-register). So the 401 unauthorized response does not trigger another
REGISTER as it would usually be the case.
So in order to allow proper de-register, include auth in this case.