Update cert-manager dependency libraries to 1.11.2 #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had to use cert-manager 1.11 for RHOS support but our libraries are still on older versions. This PR aims to update
cert-manager
libraries and its dependencies.The main problematic update that came with this is the
controller-runtime
update.The table of dependencies between cert-manager and controller-runtime looks like this:
The update to
pkg/webhooks/kafkatopic_validator_test.go
is there because KafkaTopic validating webhook unit tests started failing with the same error repeated on all err checks : (I’m pasting only one instance)That error starts from here and links to using field selectors (for "spec.name" in this particular case) during checkExistingKafkaTopicCRs().
In more detail, the error after validateKafkaTopic() when called during unit testing would be :
The fake client we use in the test didn't have the field indexers that are required for using field selectors in queries and that we normally add to our
manager
in main.go using AddKafkaTopicIndexers() (including "spec.name"). The "real" client and the "fake" client are too far apart for us to be able to apply the same function. Also, the underlying structs don't allow the same backing structures to even try.The relevant PR from controller-runtime about this (thank you, Darren!) was kubernetes-sigs/controller-runtime#2025.
I decided to only include
spec.name
for now in the test because it was the only field indexer needed for the moment out of the 3 in AddKafkaTopicIndexers().What's up with the update to pkg/resources/kafka/mocks/Client.go ?
The update to
pkg/resources/kafka/mocks/Client.go
is the result of the neededmake mock-generate
. TheClient
interface incontroller-runtime
changed in v0.14.0 and we need to generate a new mock Client.What's up with the changes to CRDs in
charts/
andconfig/
?No idea. They were generated after
make test
, I think and I would attribute them to us not having run amake
target in a previous PR.Steps taken
For me, it was :
Type of Change
Bug FixNew FeatureBreaking ChangeRefactorDocumentationChecklist