Added imagePullSecrets to deployment template

[Kuvesz]

Q	A
Bug fix?	yes
New feature?	no
API breaks?	no
Deprecations?	no
License	Apache 2.0

What's in this PR?

I added imagePullSecrets to the deployment template and updated the chart version. Also updated release.yml to not include dev tags for now in releases.

Why?

Not sure when there would be a need for this as the images are publicly accessible but just in case it doesn't hurt if it's there.

Checklist

• Implementation tested
• Error handling code meets the guideline
• Logging code meets the guideline

[CLAassistant]

All committers have signed the CLA.

[pregnor]

The change itself looks okay even though I would argue we should add commented out example code into the values.yaml.

The only use-case I could come up with would possibly be an air-gapped system with access control over the images.
I'm hesitant to approve, because I don't want additional unused code in the code base, but also don't want to block progress or uniforming things.

[Kuvesz]

The change itself looks okay even though I would argue we should add commented out example code into the values.yaml.

The only use-case I could come up with would possibly be an air-gapped system with access control over the images. I'm hesitant to approve, because I don't want additional unused code in the code base, but also don't want to block progress or uniforming things.

To be honest I'm not exactly sure we need this either as I've stated in my original comment. Everything else will be fine without it really and we can come back to this if someone from the community feels like they need it?

[pregnor]

We can let it fly as the values.yaml already contains the corresponding config.
In that sense this is really fixing a bug in the chart.

[bartam1]

I think we can remove this part after that change:

koperator/charts/kafka-operator/templates/operator-rbac.yaml

Line 4 in c30ef4c

{{- if .Values.imagePullSecrets }}

[Kuvesz]

I think we can remove this part after that change:

koperator/charts/kafka-operator/templates/operator-rbac.yaml

Line 4 in c30ef4c

{{- if .Values.imagePullSecrets }}

I don't quite get why? Would you mind explaining it a bit further?

[bartam1]

I think we can remove this part after that change:

koperator/charts/kafka-operator/templates/operator-rbac.yaml

Line 4 in c30ef4c

{{- if .Values.imagePullSecrets }}

I don't quite get why? Would you mind explaining it a bit further?

When you add an imagepullsecret into a serviceaccount then a pod which use that serviceaccount will contain the imagepullsecret what is in the serviceaccount. Here you add that imagepullsecret into the deployment anyway. Our serviceaccount imagepullsecret solution is wrong I think because when a user disable (

koperator/charts/kafka-operator/values.yaml

Line 73 in c30ef4c

create: true

) the serviceaccount creation then the imagepullsecret will not be in the default serviceaccount and in the koperator's pod.